rename function for better readability
This commit is contained in:
@@ -37,7 +37,7 @@ class ElixFormsApiClient
|
|||||||
$queryParts[] = 'moduleTag=' . rawurlencode($moduleTag);
|
$queryParts[] = 'moduleTag=' . rawurlencode($moduleTag);
|
||||||
|
|
||||||
$url = "{$this->baseUrl}/api/request/lookup/by-status?" . implode('&', $queryParts);
|
$url = "{$this->baseUrl}/api/request/lookup/by-status?" . implode('&', $queryParts);
|
||||||
$payload = $this->getJson($url, $authToken, $username, 'LookupByStatus');
|
$payload = $this->getJsonAsArray($url, $authToken, $username, 'LookupByStatus');
|
||||||
$requests = $payload['value']['requests'] ?? [];
|
$requests = $payload['value']['requests'] ?? [];
|
||||||
|
|
||||||
if (!\is_array($requests)) {
|
if (!\is_array($requests)) {
|
||||||
@@ -71,7 +71,7 @@ class ElixFormsApiClient
|
|||||||
rawurlencode($moduleTag),
|
rawurlencode($moduleTag),
|
||||||
rawurlencode($exportGroup)
|
rawurlencode($exportGroup)
|
||||||
);
|
);
|
||||||
$payload = $this->getJson($url, $authToken, $username, 'GetExportTags');
|
$payload = $this->getJsonAsArray($url, $authToken, $username, 'GetExportTags');
|
||||||
$exportTags = $payload['value']['exportTags'] ?? [];
|
$exportTags = $payload['value']['exportTags'] ?? [];
|
||||||
|
|
||||||
if (!\is_array($exportTags)) {
|
if (!\is_array($exportTags)) {
|
||||||
@@ -81,14 +81,14 @@ class ElixFormsApiClient
|
|||||||
return array_values($exportTags);
|
return array_values($exportTags);
|
||||||
}
|
}
|
||||||
|
|
||||||
private function getJson(
|
private function getJsonAsArray(
|
||||||
string $url,
|
string $url,
|
||||||
string $authToken,
|
string $authToken,
|
||||||
string $username,
|
string $username,
|
||||||
string $operation
|
string $operation
|
||||||
): array {
|
): array {
|
||||||
$response = $this->httpClient->get($url, [
|
$response = $this->httpClient->get($url, [
|
||||||
'Authorization' => 'Bearer ' . $authToken,
|
'Authorization' => "Bearer {$authToken}",
|
||||||
'Accept' => 'application/json',
|
'Accept' => 'application/json',
|
||||||
'x-requested-with' => 'XMLHttpRequest',
|
'x-requested-with' => 'XMLHttpRequest',
|
||||||
'x-api-username' => $username,
|
'x-api-username' => $username,
|
||||||
|
|||||||
Reference in New Issue
Block a user